add GCP PubSub support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/gcp-pubsub-support
branch
5 times, most recently
from
21dc933
to
253952a
Compare
svix-onelson
commented
Aug 10, 2023
svix-onelson
force-pushed
the
onelson/gcp-pubsub-support
branch
from
253952a
to
3312191
Compare
Largely this is a port of code written for `svix-bridge` in the `generic-queue` crate. Adds tests modeled after the rest of the backends here, but with GCP-specific setup and configuration. Scheduled delivery is not implemented since this is not natively supported by GCP PubSub. There are workarounds, but they rely on conventions established by calling code so I'm not sure it makes sense to codify here in the lib.
svix-onelson
force-pushed
the
onelson/gcp-pubsub-support
branch
from
3312191
to
06dd09d
Compare
svix-james
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely this is a port of code written for
svix-bridgein thegeneric-queuecrate.Adds tests modeled after the rest of the backends here, but with GCP-specific setup and configuration.
Scheduled delivery is not implemented since this is not natively supported by GCP PubSub. There are workarounds, but they rely on conventions established by calling code so I'm not sure it makes sense to codify here in the lib.