redis: Use associated type bounds to simplify RedisConnection trait (#88

)

omniqueue/Cargo.toml

@@ -6,7 +6,7 @@ description = "An abstraction layer over various queue backends"
 authors = ["Svix Inc. <[email protected]>"]
 repository = "https://github.com/svix/omniqueue-rs/"
 readme = "../README.md"
-rust-version = "1.75"
+rust-version = "1.79"
 edition = "2021"
 
 [dependencies]

omniqueue/src/backends/redis/mod.rs

@@ -65,30 +65,21 @@ pub use cluster::RedisClusterConnectionManager;
 
 pub trait RedisConnection:
     ManageConnection<
-    Connection = <Self as RedisConnection>::Connection,
-    Error = <Self as RedisConnection>::Error,
+    Connection: redis::aio::ConnectionLike + Send + Sync,
+    Error: std::error::Error + Send + Sync + 'static,
 >
 {
-    type Connection: redis::aio::ConnectionLike + Send + Sync;
-    type Error: std::error::Error + Send + Sync + 'static;
-
     fn from_dsn(dsn: &str) -> Result<Self>;
 }
 
 impl RedisConnection for RedisConnectionManager {
-    type Connection = <Self as ManageConnection>::Connection;
-    type Error = <Self as ManageConnection>::Error;
-
     fn from_dsn(dsn: &str) -> Result<Self> {
         Self::new(dsn).map_err(QueueError::generic)
     }
 }
 
 #[cfg(feature = "redis_cluster")]
 impl RedisConnection for RedisClusterConnectionManager {
-    type Connection = <Self as ManageConnection>::Connection;
-    type Error = <Self as ManageConnection>::Error;
-
     fn from_dsn(dsn: &str) -> Result<Self> {
         Self::new(dsn).map_err(QueueError::generic)
     }
@@ -113,7 +104,7 @@ async fn check_eviction_policy<R: RedisConnection>(
     let results: Vec<String> = redis::cmd("CONFIG")
         .arg("GET")
         .arg("maxmemory-policy")
-        .query_async::<<R as RedisConnection>::Connection, Vec<String>>(&mut *conn)
+        .query_async::<R::Connection, Vec<String>>(&mut *conn)
         .await
         .map_err(|_| EvictionCheckError::CheckEvictionPolicyFailed)?;