[NDB] Change warning to work with Python < 3.6 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothée Dzik <[email protected]>
|
Forgot to introduce myself, I'm Tim currently working on magma an open-source software platform that gives network operators an open, flexible and extendable mobile core network solution. Thanks for your pyroute2 lib! 👯 |
|
@tmdzk sure, thanks! What do you think, may it be a good idea to tag a release? |
|
hey @svinota, thanks for your fast reply! I think it is a good idea to tag a release. |
|
done, and I hope nothing gets broken :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timothée Dzik [email protected]
[NDB] Change warning to work with Python < 3.6
Summary
In the latest 0.5.15 this line has been included which work on
Python >= 3.6but not onPython < 3.6Simple fix, change the way to inject the var in the warning.