Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetNS leaks FDs #623

Closed
ndesh26 opened this issue Jul 29, 2019 · 0 comments · Fixed by #624
Closed

NetNS leaks FDs #623

ndesh26 opened this issue Jul 29, 2019 · 0 comments · Fixed by #624

Comments

@ndesh26
Copy link

ndesh26 commented Jul 29, 2019

After the change in behavior of the Transport object in the commit 4420185, NetNS leaks FDs.

After the commit Transport.close() doesn't close the file_obj associated with it. We are supposed to close it manually after the call to close(). This leads to a FD leak in the __init__ function.
ndesh26 pushed a commit to ndesh26/pyroute2 that referenced this issue Jul 29, 2019
NetNS: fix the FD leakage
19fa973 
With the change in the behavior of the Transport object, we now need to
close the file_obj associated with the Transport object manually.

Closes svinota#623
@ndesh26 ndesh26 mentioned this issue Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NetNS: fix the FD leakage ndesh26/pyroute2
1 participant
@ndesh26