Attempt to apply aria-labelledby and role attributes by default / Support custom attrs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to be a further enhancement after #8.
As this Codepen demonstrates, svg symbols have the potential to offer extra information for screen readers if the proper combination of the
aria-labelledbyandroleattributes are applied.The changes here update the symbol parsing functionality to attempt to include
aria-labelledbyandroleby default, and while I was at it, I figured it would be even better to also allow for custom attributes to be passed as a config option. The parsing function simply iterates through the list of all the attributes the user wants it to include on the symbol, and applies them if they're found on the original SVG.