Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update ESLint to v9 and switch to flat config #2001

Merged
merged 3 commits into from
May 26, 2024
Merged

chore: update ESLint to v9 and switch to flat config #2001

merged 3 commits into from
May 26, 2024

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 9, 2024 •
edited
Loading

Requires #1987 and probably a rebase after that is merged

@XhmikosR XhmikosR mentioned this pull request May 9, 2024
Merged
@XhmikosR XhmikosR force-pushed the xmr/update-eslint branch 4 times, most recently from 9aa392f to fe1c02f Compare May 14, 2024 18:34
@XhmikosR XhmikosR marked this pull request as ready for review May 14, 2024 18:35
XhmikosR and others added 2 commits May 26, 2024 08:41
@SethFalco
Copy link
Member

I added a commit that makes the following changes:

  • Drops the comment of global ignores as the section is fairly self-explanatory and the JS Docs explain what the property does.
  • Dropped some of the implicit values, namely treating .js and .mjs as ESM and .cjs as CJS. This is just to simplify the config, since the default values are already intuitive.

Meanwhile, LGTM! Thanks for helping with some of the chores!

@SethFalco SethFalco merged commit 4daaa42 into svg:main May 26, 2024
10 checks passed
@XhmikosR XhmikosR deleted the xmr/update-eslint branch May 27, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @SethFalco