Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cleanupIds): handle no-uri-encoded references #1982

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix(cleanupIds): handle no-uri-encoded references #1982

merged 3 commits into from
Apr 25, 2024

Conversation

liuweifeng
Copy link
Contributor

fixed #1981 .

SethFalco
SethFalco reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment as I believe there is a vulnerability in this version.

Overall, the issue and solution makes sense though. Thanks for submitting a patch!

plugins/cleanupIds.js Outdated Show resolved Hide resolved
test/plugins/cleanupIds.26.svg.txt Outdated Show resolved Hide resolved
@SethFalco SethFalco merged commit 89b0c6c into svg:main Apr 25, 2024
8 checks passed
@SethFalco
Copy link
Member

Thanks for spotting the issue and submitting a patch! This will be released by the end of the month.

@dougmendes dougmendes mentioned this pull request May 31, 2024
Open
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@Latteflo Latteflo mentioned this pull request Jul 18, 2024
Open
johnkenny54 added a commit to johnkenny54/svgo that referenced this pull request Aug 12, 2024
@johnkenny54
Updated to include changes for PR svg#1982
794145f
@WontonSam WontonSam mentioned this pull request Sep 20, 2024
Open
@EmmanuelDemey EmmanuelDemey mentioned this pull request Sep 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethFalco SethFalco SethFalco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cleanupIDs] symbol is incorrectly removed when its ID is *NOT* used by URL-encoded reference
2 participants
@liuweifeng @SethFalco