fix(convertPathData): preserve vertex for markers only path #1967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get a markers only path, for example:
(The path only serves to draw the referenced markers.)
We ensure it always has an extra vertex if it had multiple vertices before optimization. If it did not have multiple vertices, for example it was
M
/m
commands only, then it has the same behavior as before.See my comment on the related issue for more info:
In short, clients consistently render the marker only when a command other than
M
orm
are used in the path data. If this is removed, in some clients the markers are no longer rendered.It's unclear from the spec what the intended behavior is, but across all clients, rendering is impacted when no additional vertices are in the path.
Related