Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all configuration in the <style /> element #1736

Merged
merged 1 commit into from
Dec 9, 2023

Commits on Dec 9, 2023

  1. Include all configuration in the <style /> element

    This fixes a bug in the prefixIds plugin.  It assumed that the <style />
    element will have a single text fragment underneath.
    
    So this works:
    <style>
    <!-- Leading comment ignored -->
    .class1 {}
    ...
    .classN {}
    </style>
    
    The above parses so that node.children[0] is a "text" node with all the
    CSS classes where "node" is the style element.
    
    And this fails:
    <style>
    <!-- Ignored comment -->
    .class1 {}
    <!-- comment -->
    .class2 {}
    </style>
    
    This fails because only node.children[0] is processed and node.children
    looks something like:
    [
    .class1 (type = "text")
    comment (type = "comment")
    .class2 (type = "text")
    ]
    john-neptune authored and SethFalco committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    6c3eb09 View commit details
    Browse the repository at this point in the history