Refactor prefixIds #1561
Merged
Refactor prefixIds #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the error is caused by this |
TrySound
force-pushed
the
refactor-prefix-ids
branch
from
27d405a
to
9a886e4
Compare
|
Build is fixed! |
matheus1lva
approved these changes
Sep 11, 2021
Ref #1499 - migrated to visitor plugin api - covered with tsdoc - made the plugin idempotent as requested a few times Now even manually running svgo a few times will not duplicate prefix in ids and classes - run each plugin test twice to see which plugin need to run many times ideally idempotent plugins will allow to get rid of multipass option in v3
TrySound
force-pushed
the
refactor-prefix-ids
branch
from
6c9de2b
to
684cce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanupIDsandprefixIdsdoes not work as expected #1406)Now even manually running svgo a few times will not duplicate
prefix in ids and classes ( Multiple runs using prefixIds will cause the id to be prefixed multiple times. #1499)
ideally idempotent plugins will allow to get rid of multipass option in v3
cc @strarsis