Refactor cleanupIDs #1556
Merged
Refactor cleanupIDs #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still did get how id generation works but data flow is clear now at least. - covered with types - migrated to visitor plugin api - got rid of traverse api
mrazauskas
reviewed
Sep 3, 2021
Comment on lines
+226
to
+231
| let refs = referencesById.get(id); | ||
| if (refs == null) { | ||
| refs = []; | ||
| referencesById.set(id, refs); | ||
| } | ||
| refs.push({ element: node, name, value }); |
There was a problem hiding this comment.
Might be I missed something. Isn’t this the same, but slightly shorter:
const refs = referencesById.get(id) || [];
if (!refs.length) {
referencesById.set(id, refs);
}
refs.push({ element: node, name, value });There was a problem hiding this comment.
Yes, though I prefer more explicit null check, length check is less obvious
There was a problem hiding this comment.
Sure. I was just looking around for examples. Working on a custom plugin. Just to say, Visitor API is a pleasure to use.
There was a problem hiding this comment.
Thanks. All plugins will use visitor api. full, perItem and perItemReverse will be removed in v3.
matheus1lva
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still did get how id generation works but data flow is clear now at
least.