Replace mkdirp with fs.mkdir with recursive flag #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @GreLI |
realityking
reviewed
Nov 13, 2020
package.json
Outdated
| @@ -73,7 +72,7 @@ | |||
| "should": "~13.2.3" | |||
| }, | |||
| "engines": { | |||
| "node": ">=4.0.0" | |||
| "node": ">=10.0.0" | |||
There was a problem hiding this comment.
Suggested change
| "node": ">=10.0.0" | |
| "node": ">=10.12.0" |
According to the docs, this was only added in 10.12
Ref https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_fs_mkdir_path_options_callback Node 10 add "recursive" flag support to fs.mkdir which behaves similar to mkdirp package. Though this requires to bump node support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_fs_mkdir_path_options_callback
Node 10 add "recursive" flag support to fs.mkdir which behaves similar
to mkdirp package.
Though this requires to bump node support.