Add workaround/fix for node v6 selector exception handling #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strarsis
changed the title
This was referenced Jan 4, 2020
Closed
|
I'm dropping node 6 and 8 support now. This change is not necessary in v10+, right? |
|
@TrySound: Right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GreLI: This PR adds a workaround/fix for selector exception handling in node v6.
This fixes the currently failing build of current master (Travis node v6): https://travis-ci.org/svg/svgo/jobs/623319182#L880
The reason is that in node v6 the
constructorproperty of an exception that is thrown bycss-select, when a selector doesn't match (which normally happens all the time), is justErrorinstead ofSyntaxError. All exceptions other thanSyntaxErrorare re-thrown, but when the constructor is justErrorin node v6, one is unable to differentiate. As an alternative for node v6, the exceptionmessageis matched by the error message.