feat(removeScriptElement): add all known event types (#1819)

Update the list of event attributes to include everything listed on MDN.
svg · Nov 4, 2023 · e21e560 · e21e560
1 parent e73ee2d
commit e21e560
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 3 deletions.
diff --git a/lib/svgo/tools.js b/lib/svgo/tools.js
@@ -167,8 +167,10 @@ const hasScripts = (node) => {
 
   const eventAttrs = [
     ...attrsGroups.animationEvent,
-    ...attrsGroups.graphicalEvent,
     ...attrsGroups.documentEvent,
+    ...attrsGroups.documentElementEvent,
+    ...attrsGroups.globalEvent,
+    ...attrsGroups.graphicalEvent,
   ];
 
   return eventAttrs.some((attr) => node.attributes[attr] != null);

diff --git a/plugins/_collections.js b/plugins/_collections.js
@@ -218,13 +218,72 @@ exports.attrsGroups = {
     'xlink:title',
   ],
   documentEvent: [
-    'onunload',
     'onabort',
     'onerror',
     'onresize',
     'onscroll',
+    'onunload',
     'onzoom',
   ],
+  documentElementEvent: ['oncopy', 'oncut', 'onpaste'],
+  globalEvent: [
+    'oncancel',
+    'oncanplay',
+    'oncanplaythrough',
+    'onchange',
+    'onclick',
+    'onclose',
+    'oncuechange',
+    'ondblclick',
+    'ondrag',
+    'ondragend',
+    'ondragenter',
+    'ondragleave',
+    'ondragover',
+    'ondragstart',
+    'ondrop',
+    'ondurationchange',
+    'onemptied',
+    'onended',
+    'onerror',
+    'onfocus',
+    'oninput',
+    'oninvalid',
+    'onkeydown',
+    'onkeypress',
+    'onkeyup',
+    'onload',
+    'onloadeddata',
+    'onloadedmetadata',
+    'onloadstart',
+    'onmousedown',
+    'onmouseenter',
+    'onmouseleave',
+    'onmousemove',
+    'onmouseout',
+    'onmouseover',
+    'onmouseup',
+    'onmousewheel',
+    'onpause',
+    'onplay',
+    'onplaying',
+    'onprogress',
+    'onratechange',
+    'onreset',
+    'onresize',
+    'onscroll',
+    'onseeked',
+    'onseeking',
+    'onselect',
+    'onshow',
+    'onstalled',
+    'onsubmit',
+    'onsuspend',
+    'ontimeupdate',
+    'ontoggle',
+    'onvolumechange',
+    'onwaiting',
+  ],
   filterPrimitive: ['x', 'y', 'width', 'height', 'result'],
   transferFunction: [
     'type',

diff --git a/plugins/removeScriptElement.js b/plugins/removeScriptElement.js
@@ -9,8 +9,10 @@ exports.description = 'removes scripts (disabled by default)';
 /** Union of all event attributes. */
 const eventAttrs = [
   ...attrsGroups.animationEvent,
-  ...attrsGroups.graphicalEvent,
   ...attrsGroups.documentEvent,
+  ...attrsGroups.documentElementEvent,
+  ...attrsGroups.globalEvent,
+  ...attrsGroups.graphicalEvent,
 ];
 
 /**