Skip to content

Commit

Permalink
Add Github Issue Templates (#1367)
Browse files Browse the repository at this point in the history
* Path intersection was not checking paths with circles.

As an optimization the path intersection was checking the paths had three or more elements, caliming that otherwise there was nothing to fill. However a semi circle would actually contain 2 points.

Fixes #1048.

This adds a simplified test case for the 2 offending files reported in the issue.

* Add issue templates

We add issue templates for:

- Bug Reports
- Feature Requests
- Plugin Requests
- Pull Requests
- Questions

* Add Github issue templates

Fixes #1364, but is is missing the template for pull requests see
https://docs.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

* fix

* Use "New plugin" label

Co-authored-by: Bogdan Chadkin <[email protected]>
  • Loading branch information
sk- and TrySound authored Feb 22, 2021
1 parent 9b97e06 commit aa8e0bd
Show file tree
Hide file tree
Showing 4 changed files with 79 additions and 0 deletions.
32 changes: 32 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- SVGO Version [e.g. 2.0.3]
- NodeJs Version [e.g 14.0.4]
- OS: [e.g. iOS]

**Additional context**
Add any other context about the problem here.
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: Questions
url: https://stackoverflow.com/questions/tagged/svgo
about: Please ask and answer questions on StackOverflow with the svgo tag.
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
22 changes: 22 additions & 0 deletions .github/ISSUE_TEMPLATE/plugin_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Plugin request
about: Suggest a plugin for this project
title: ''
labels: 'New plugin'
assignees: ''

---

**Is your plugin request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe what the plugin should do**
A clear and concise description of what you want to happen.

<!-- Please include a sample SVG and a resulting SVG -->

**Additional context**
Include any links pointing to relevant specs or general knowledge that may validate your plugin idea.

**Implementation**
- [ ] Are you volunteering to work on this plugin?

0 comments on commit aa8e0bd

Please sign in to comment.