Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize namespaces and clean up exception handling. #4

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

johnkenny54
Copy link
Contributor

  • force elements in the SVG namespace to have no prefix (current architecture does not handle namespaces and prefixes).
  • force force attributes in the xlink namespace to have xlink: prefix (many plugins are hard-coded to this prefix)
  • throw an Error if non-svg default namespace is encountered outside of a foreignObject
  • change optimize() to not throw an Error if there is a parse error - warning message is printed, input string is returned unchanged, and Error is added to return object

@johnkenny54 johnkenny54 merged commit d5166e6 into svg-utils:main Sep 18, 2024
9 checks passed
@johnkenny54 johnkenny54 deleted the namespaces branch September 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant