-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding custom attributes to rootAttributes
#87
Comments
Hi @iMoses, thanks for the suggestion. In general I agree, although I think it shouldn't be svg-sprite's job to do these kind of SVG modifications. For a lot of users the available configuration options are already overwhelming enough. ;) However, I already considered adding a global post-transformation on the final sprite, which would totally suit your need. Due to my current workload this will take me some time to implement though. Thanks for your patience. Cheers, |
Are you expecting code contributions? |
I fully agree that splitting of a fork just because of this one wouldn't make much sense. However, I also don't think svg-sprite should have extra options for each and every special case, so using a generic post-transformation for this (and other) modifications seems right to me. I'll put this high on my schedule, ok? |
Okay, thanks. P.S. I agree, the best solution in this case should be generic, not specific. |
As of release v1.2.0 there are now two options to add custom root attributes:
I'm pretty sure you can now achieve what you wanted to, right? Cheers, |
Is it possible? Unless I missed something it doesn't seem to be extendable.
I think it's an important and easy enough feature/option to add.
If there's a way I'd like to hear about it and if not then consider this as a feature request.
The text was updated successfully, but these errors were encountered: