-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix improperly configured error showing #136
Conversation
a88f62d
to
82e206a
Compare
index.js
Outdated
@@ -13,6 +13,7 @@ | |||
/** @typedef {import('stream').TransformOptions} TransformOptions */ | |||
|
|||
const { Transform } = require('stream'); | |||
const util = require('util'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XhmikosR I'm not sure how to proceed here
'node:utils' available after Node v14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you just ignore the rule in package.json and we re-enable it after svg-sprite v3.0.0 where we drop support for Node.js < 14
I assume you tested it, @Kreeg, right? I don't really use gulp or grunt a lot nowadays :) I can make a new release after this is merged. |
I changed svg-sprite package's file to throw errors and it seems to do well
Sometimes we rely on winston logger, like
I think these should be unified |
Your call, but I agree we should be consistent. BTW, if we could replace winston with something smaller that has the same features we currently use that would make more sense. |
@XhmikosR hello. I think we're ready for new release. |
Fixes #82