Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduces use of node imports aliasses in package.json #851

Merged
merged 13 commits into from
Oct 9, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 8, 2023

Description

Use import aliases in package.json for ...

  • utl/*
  • meta.js
  • graph-utl/*
  • extract/*
  • enrich/*
  • report/*
  • main/*
  • cache/*
  • cli/*
  • the json schemas
  • validate/*
  • config-utl/*

Motivation and Context

  • Makes code easier to read (and move around, might it come to that)
  • Dog fooding a feature I've not used in any other project

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij changed the title refactor: uses node imports aliasses in package.json for central modules refactor: introduces use of node imports aliasses in package.json Oct 8, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023

Code Climate has analyzed commit ef970df and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit f249954 into main Oct 9, 2023
6 checks passed
@sverweij sverweij deleted the refactor/use-node-aliasses-for-central-modules branch October 9, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant