Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adds reaches filter option #635

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jul 16, 2022

Description

  • adds a reaches filter to the options
  • adds a -R, --reaches filter option to the depcruise CLI
  • adds a -R, --reaches filter option to the depcruise-fmt CLI

Motivation and Context

How Has This Been Tested?

  • green ci
  • additional automated unit/ integration tests

Screenshots

To see all modules changed in this PR + all modules affected by it I've run:

depcruise --include-only ^src --reaches "$(watskeburt develop)" -T dot | dot -T svg > diff.s
vg

which yields this graph:

diff

as you see it's currently not a feature yet to 'highlight' the modules that match
the reaches filter like what is possible in the --focus filter. That feature
might follow in a future PR.

depcruise --include-only ^src --focus "$(watskeburt develop)" -T dot | dot -T svg > diff.svg

yielding ...

diff

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the feature/adds-reaches-option branch from 06da277 to f463c3e Compare July 16, 2022 20:12
@sverweij sverweij merged commit f13d637 into develop Jul 17, 2022
@sverweij sverweij deleted the feature/adds-reaches-option branch July 17, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: graph showing only the dependent modules
1 participant