feat(reporter/dot): only considers rule severity for coloring invalid…

… modules/ dependencies (#869)

## Description, Motivation and Context

- _only_ color modules & dependencies in one of the severity level
colors when there's a severity set on the associated rule

The default `dot` configuration built into dependency-cruiser made that
things that were invalid, but for which the rule was _ignored_ showed up
with a red color. This is obviously not helpful (why otherwise ignore
the rule).

## How Has This Been Tested?

- [x] green ci
- [x] adjusted automated non-regression tests

## Types of changes

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Documentation only change
- [ ] Refactor (non-breaking change which fixes an issue without
changing functionality)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

src/report/dot/default-theme.mjs

@@ -46,14 +46,6 @@ export default {
       criteria: { "rules[0].severity": "info" },
       attributes: { fontcolor: "blue", color: "blue" },
     },
-    {
-      criteria: { valid: false },
-      attributes: { fontcolor: "red", color: "red" },
-    },
-    {
-      criteria: { couldNotResolve: true },
-      attributes: { color: "red", fontcolor: "red" },
-    },
     {
       criteria: { coreModule: true },
       attributes: { color: "grey", fontcolor: "grey" },
@@ -131,10 +123,6 @@ export default {
       criteria: { dynamic: true },
       attributes: { style: "dashed" },
     },
-    {
-      criteria: { valid: false },
-      attributes: { fontcolor: "red", color: "red" },
-    },
     {
       criteria: { circular: true },
       attributes: { arrowhead: "normalnoneodot" },

test/report/dot/theming.spec.mjs

@@ -25,7 +25,7 @@ describe("[U] report/dot/theming - determineModuleColors - default theme", () =>
         { couldNotResolve: true },
         theming.normalizeTheme({}).modules,
       ),
-      { color: "red", fontcolor: "red" },
+      {},
     );
   });