Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache mismatch Jekyll 4.0 #195

Closed
wants to merge 5 commits into from

Conversation

jameshi16
Copy link

@jameshi16 jameshi16 commented May 27, 2020

Hello!

I had a problem with jemoji rendering on my index page, and pinpointed the problem to the new caching mechanism introduced by Jekyll 4.0. (I had index.html, page1.html and page2.html that required pagination, all of them appeared as .html in the Rendering stage)

Carrying on from the work done by @mohkale in #182, I've addressed the latest comments to include index.html. This seems to fix my problems, so I've decided to open a PR.

It should now output:

         Rendering: bar/index.html
  Pre-Render Hooks: bar/index.html
  Rendering Liquid: bar/index.html
  Rendering Markup: bar/index.html
  Rendering Layout: bar/index.html
         Rendering: foo/index.html
  Pre-Render Hooks: foo/index.html
  Rendering Liquid: foo/index.html
  Rendering Markup: foo/index.html
  Rendering Layout: foo/index.html

Thank you in advance for a review 😄

@sverrirs
Copy link
Owner

sverrirs commented May 2, 2021

This issue may have been addressed in #215, do you have the possibility to verify?

@jameshi16
Copy link
Author

@sverrirs, the issue has been addressed. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants