Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Restriction with an Identity Provider appears to be non-functional #114

Closed
1 task done
emixam54 opened this issue Oct 21, 2022 · 4 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@emixam54
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I am configuring the access restriction. I have no problem restricting access using Username Password Form. However, as soon as I use the configured identity provider, the restriction never applies.

Expected Behavior

The same operation between the Username/password connection and the identifty provider connection.

Steps To Reproduce

Here is the connection flow I have:

image

Version

- Keycloak: 19.0.1 (quarkus)
- This extension: 19.0.0

Anything else?

I searched through the existing issues, I did not find a clue to solve my problem. Sorry if this is the case.

I also wondered about "is this prodider supposed to work with an Identity Provider?". The only answer I could find in the README is here. And it just says, that this provider is better than the "Allow/Deny Access" feature which doesn't work with identity providers.

In any case, thank you for your work!

@emixam54 emixam54 added the bug Something isn't working label Oct 21, 2022
@sventorben
Copy link
Owner

Hello @mdurand54,

thanks for reporting this.
I am afraid this is an issue with sub-flows and authenticators in combination with identity provider redirection in general and not limited to this authenticator.

You will have to configure post login flow for every identity provider.

This has also already been discussed in KEYCLOAK-19538 and seems to be by design.

Best regards
Sven-Torben

@sventorben sventorben self-assigned this Oct 21, 2022
@sventorben sventorben added the wontfix This will not be worked on label Oct 21, 2022
@emixam54
Copy link
Author

Oh okay. Thanks for the explanation.

So, I'm trying to configure a post login flow. Would it make sense to keep only the cookie and the authenticator part post login flow. Something like:

  • Login (required)
    • Cookie (required)
  • Restrict user authentication on clients -> (required)

@sventorben
Copy link
Owner

You may not even need the cookie authenticator, because that is generally checked before the IdP redirect already. If a sso cookie is present in the request, you should not get redirected to the IdP.
Simply having this extension in your post login flow should be sufficient.

@emixam54
Copy link
Author

Effectively, the extension is sufficient in the post login flow.

Thank you very much for your help!

@sventorben sventorben added the documentation Improvements or additions to documentation label Oct 26, 2022
sventorben added a commit that referenced this issue Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants