add read-only webdav support #1415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahti
force-pushed
the
webdav
branch
5 times, most recently
from
c6a083c
to
6f082ad
Compare
ahti
changed the title
svenstaro
requested changes
Sep 22, 2024
| @@ -308,7 +315,9 @@ fn configure_header(conf: &MiniserveConfig) -> middleware::DefaultHeaders { | |||
| /// This is where we configure the app to serve an index file, the file listing, or a single file. | |||
| fn configure_app(app: &mut web::ServiceConfig, conf: &MiniserveConfig) { | |||
| let dir_service = || { | |||
| let mut files = actix_files::Files::new("", &conf.path); | |||
| // use routing guard so propfind and options requests fall through to the webdav handler | |||
There was a problem hiding this comment.
Do we want all Options requests to fall through? Can we be more specific?
| // order is important: the dir service above is checked first, but has a method guard, | ||
| // so options and propfind go here. if this service was registered first, it would swallow the gets/heads | ||
| app.service( | ||
| web::resource("/{tail:.*}") |
Comment on lines
+1
to
+3
| use dav_server::{davpath::DavPath, fs::*, localfs::LocalFs}; | ||
| use futures::{future::ready, StreamExt, TryFutureExt}; | ||
| use std::path::{Component, Path}; |
There was a problem hiding this comment.
Give this module a description.
Comment on lines
+5
to
+9
| #[derive(Clone)] | ||
| pub struct RestrictedFs { | ||
| local: Box<LocalFs>, | ||
| allow_hidden: bool, | ||
| } |
There was a problem hiding this comment.
Give this a proper description of what this is supposed to do and why we need it.
| } | ||
| } | ||
|
|
||
| fn check_path(path: &DavPath) -> bool { |
There was a problem hiding this comment.
Describe what the idea here is.
|
Please rebase this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds read-only webdav support by (when indexing isn't disabled) routing OPTIONS/PROPFIND requests to a
DavHandlerfrom thewebdav-servercrate. Hidden files are excluded via a customDavFileSystem.