Fix author and version metadata in subcommands #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of the subcommands has a hard coded version of 1.0 and a hard-coded author name. This commit instead pulls this information directly from `Cargo.toml`, so that it can be upgraded from a centralized location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the subcommands has a hard coded version of 1.0 and a hard-coded author name. This commit instead pulls this information directly from
Cargo.toml, so that it can be upgraded from a centralized location.I noticed this because it seems that the
--keepflag is an enhancement not available on the version ofcargo-profileron crates.io, but I was erroneously seeing the version as 1.0.One thing to note: the
Cargo.tomlhaspegasos1as the original author, but the.authorcalls had "Suchin Gururangan". Should we also changeauthorslike so?authors = ["Suchin Gururangan <pegasos1>", "Sven Hendrik Haase <[email protected]>"]