Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend nib API to allow reuse of underlying writer #21

Closed
svengreb opened this issue Oct 31, 2020 · 0 comments · Fixed by #22
Closed

Extend nib API to allow reuse of underlying writer #21

svengreb opened this issue Oct 31, 2020 · 0 comments · Fixed by #22
Labels
context-api context-pkg scope-compatiblity scope-ux type-feature
Milestone
0.2.0

Comments

@svengreb
Copy link
Owner

svengreb commented Oct 31, 2020 •
edited
Loading

To allow to reuse the underlying io.Writer a new Writer() io.Writer method will be added to the nib.Nib interface.
Both implementations the pencil package][p] and [inkpen` package will adapt to this change.
@svengreb svengreb added this to the 0.2.0 milestone Oct 31, 2020
@svengreb svengreb self-assigned this Oct 31, 2020
svengreb added a commit that referenced this issue Oct 31, 2020
@svengreb
Extend nib API to allow reuse of underlying writer
cf5c5cb 
To allow to reuse the underlying io.Writer [1] a new
`Writer() io.Writer` method has been added to the `nib.Nib` interface
[2].
Both implementations the `pencil package [3] and `inkpen` package [4]
adapted this change.

[1]: https://pkg.go.dev/github.com/svengreb/nib#Nib
[2]: https://golang.org/pkg/io/#Writer
[3]: https://pkg.go.dev/github.com/svengreb/nib/pencil
[4]: https://pkg.go.dev/github.com/svengreb/nib/inkpen

GH-21
@svengreb svengreb mentioned this issue Oct 31, 2020
Merged
svengreb added a commit that referenced this issue Oct 31, 2020
@svengreb
Extend nib API to allow reuse of underlying writer
329e934 
To allow to reuse the underlying io.Writer [1] a new
`Writer() io.Writer` method has been added to the `nib.Nib` interface
[2].
Both implementations the `pencil package [3] and `inkpen` package [4]
adapted this change.

[1]: https://pkg.go.dev/github.com/svengreb/nib#Nib
[2]: https://golang.org/pkg/io/#Writer
[3]: https://pkg.go.dev/github.com/svengreb/nib/pencil
[4]: https://pkg.go.dev/github.com/svengreb/nib/inkpen

GH-21
svengreb added a commit that referenced this issue Oct 31, 2020
@svengreb
Extend nib API to allow reuse of underlying writer (#22)
2dac339 
To allow to reuse the underlying io.Writer [1] a new
`Writer() io.Writer` method has been added to the `nib.Nib` interface
[2].
Both implementations the `pencil package [3] and `inkpen` package [4]
adapted this change.

[1]: https://pkg.go.dev/github.com/svengreb/nib#Nib
[2]: https://golang.org/pkg/io/#Writer
[3]: https://pkg.go.dev/github.com/svengreb/nib/pencil
[4]: https://pkg.go.dev/github.com/svengreb/nib/inkpen

Closes GH-21
@svengreb svengreb removed their assignment Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-api context-pkg scope-compatiblity scope-ux type-feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Extend nib API to allow reuse of underlying writer svengreb/nib
1 participant
@svengreb