Fix method redefinition warnings when pluralizations are reloaded #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
approved these changes
Sep 23, 2024
|
Thank you! Could you include an entry to the CHANGELOG? 🙏🏻 |
casperisfine
force-pushed
the
reloading-safe
branch
from
fce5a35 to
bf1bcf3
Compare
Fix: svenfuchs#735 Whenever pluralization rules are reloaded it causes a lot of warnings: ``` lib/rails_i18n/../../rails/pluralization/ar.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/ar.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/gd.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/gd.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/hsb.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/hsb.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/lt.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/lt.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/lv.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/lv.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/mk.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/mk.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/pl.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/pl.rb:4: warning: previous definition of rule was here lib/rails_i18n/../../rails/pluralization/sl.rb:4: warning: method redefined; discarding old rule lib/rails_i18n/../../rails/pluralization/sl.rb:4: warning: previous definition of rule was here ... ``` This is mostly harmless, but annoying for users who try to run with no warnings at all.
casperisfine
force-pushed
the
reloading-safe
branch
from
bf1bcf3 to
8b32b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #735
Whenever pluralization rules are reloaded it causes a lot of warnings:
This is mostly harmless, but annoying for users who try to run with no warnings at all.
cc @pama
NB: I chose not to split this code in lots of small files because I don't think it's particularly useful. But if you think it is I can do it.