Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): compile files in /node_modules/ with hmr: false #949

Closed
wants to merge 2 commits into from

Conversation

dominikg
Copy link
Member

this saves some time and space, but also ensures consistency in cssHash which avoids bugs like sveltejs/svelte#12601

@Conduitry
Copy link
Member

Hm. Could someone conceivably have an npm linked dependency here that they still want HMR for?

@dominikg
Copy link
Member Author

Hm. Could someone conceivably have an npm linked dependency here that they still want HMR for?

for that they would have to add the dep to optimizeDeps.exclude or it would be prebundled which prevents hmr too. but for comparability i'll post a different fix that updates cssHash instead.

@dominikg
Copy link
Member Author

losing in favor of #950

@dominikg dominikg closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants