Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add svelte/internal/disclose-version to optimizeDeps.include #692

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix: add svelte/internal/disclose-version to optimizeDeps.include #692

merged 2 commits into from
Jul 21, 2023

Conversation

dominikg
Copy link
Member

it's used internally by svelte4, but vite dynamically discovering it leads to

9:33:40 PM [vite] ✨ new dependencies optimized: svelte/internal/disclose-version
9:33:40 PM [vite] ✨ optimized dependencies changed. reloading

so add it to our internal list thats used to generate optimizeDeps.include

@dominikg dominikg merged commit a8f13f0 into main Jul 21, 2023
7 checks passed
@dominikg dominikg deleted the fix/svelte-version branch July 21, 2023 14:09
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikg @bluwy