Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't transform bidi transitions twice #970

Merged
merged 1 commit into from
Dec 3, 2017
Merged

don't transform bidi transitions twice #970

merged 1 commit into from
Dec 3, 2017

Conversation

Rich-Harris
Copy link
Member

fixes the regression in #962 that would fail on bidirectional transitions that referenced state

@codecov-io
Copy link

codecov-io commented Dec 3, 2017

Codecov Report

Merging #970 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   91.84%   91.86%   +0.02%     
==========================================
  Files         112      112              
  Lines        4107     4108       +1     
  Branches     1332     1330       -2     
==========================================
+ Hits         3772     3774       +2     
  Misses        143      143              
+ Partials      192      191       -1
Impacted Files Coverage Δ
.../generators/dom/visitors/Element/addTransitions.ts 96.66% <100%> (+3.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832311a...3350f16. Read the comment docs.

@Rich-Harris Rich-Harris merged commit e0d00d0 into master Dec 3, 2017
@Rich-Harris Rich-Harris deleted the gh-962-again branch December 3, 2017 18:57
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants