Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parameterised transitions #963

Merged
merged 3 commits into from
Nov 27, 2017
Merged

allow parameterised transitions #963

merged 3 commits into from
Nov 27, 2017

Conversation

Rich-Harris
Copy link
Member

Fixes #962. I managed to break parameterised transitions in #924 😬

@Rich-Harris Rich-Harris merged commit b26be1c into master Nov 27, 2017
@Rich-Harris Rich-Harris deleted the gh-962 branch November 27, 2017 12:42
@codecov-io
Copy link

Codecov Report

Merging #963 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   91.73%   91.76%   +0.03%     
==========================================
  Files         109      109              
  Lines        4051     4054       +3     
  Branches     1300     1301       +1     
==========================================
+ Hits         3716     3720       +4     
  Misses        150      150              
+ Partials      185      184       -1
Impacted Files Coverage Δ
src/generators/Generator.ts 93.93% <100%> (+0.05%) ⬆️
.../generators/dom/visitors/Element/addTransitions.ts 93.1% <33.33%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a717c82...faf5ca8. Read the comment docs.

sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
…#963)

Update comments on utils.js for clarity and accuracy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants