Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append to the dom, not a document fragment, when updating each block in slot #932

Merged
merged 3 commits into from
Nov 23, 2017

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Nov 18, 2017

fixes #927

@Rich-Harris Rich-Harris changed the title [WIP] failing test for #927 append to the dom, not a document fragment, when updating each block in slot Nov 23, 2017
@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #932 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         109      109           
  Lines        4001     4001           
  Branches     1283     1283           
=======================================
  Hits         3670     3670           
  Misses        148      148           
  Partials      183      183
Impacted Files Coverage Δ
src/generators/dom/visitors/EachBlock.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a01aa0...2f86266. Read the comment docs.

@Rich-Harris Rich-Harris merged commit d32328c into master Nov 23, 2017
@Rich-Harris Rich-Harris deleted the gh-927 branch November 23, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each block inside slotted content does not get updated
2 participants