Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repl): runes bottom banner overlapping fixed #9238

Merged
merged 5 commits into from
Sep 21, 2023
Merged

fix(repl): runes bottom banner overlapping fixed #9238

merged 5 commits into from
Sep 21, 2023

Conversation

irshad
Copy link
Contributor

@irshad irshad commented Sep 21, 2023 •
edited
Loading

The issue of overlapping runes bottom banner on the REPL has been resolved.

Svelte compiler rewrite

Please note that the Svelte codebase is currently being rewritten. Thus, it's best to hold off on new features or refactorings for the time being.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@irshad
Update +layout.svelte
a2bb211 
The issue of overlapping runes bottom banner on the REPL has been resolved.
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ec7f09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@irshad irshad changed the title Update +layout.svelte fix(repl): runes bottom banner overlapping fixed Sep 21, 2023
PuruVJ
PuruVJ approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@PuruVJ PuruVJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@dummdidumm dummdidumm merged commit fa89421 into sveltejs:master Sep 21, 2023
5 of 6 checks passed
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
@irshad @dummdidumm @kelvinsjk
fix(repl): runes bottom banner overlapping fixed (sveltejs#9238)
b03109f 
---------

Co-authored-by: Simon H <[email protected]>
Co-authored-by: Simon Holthausen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuruVJ PuruVJ PuruVJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irshad @PuruVJ @dummdidumm