Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to preserve unused css selectors #9192

Closed
wants to merge 2 commits into from

Conversation

Maytha8
Copy link

@Maytha8 Maytha8 commented Sep 10, 2023

Hello Svelte contributors,

This PR proposes to add a compile option, preserveUnusedSelectors, that keeps unused stylesheet selectors when set to true. It is set to false by default, which means it does not affect previous behaviour and is not a breaking change. I've also written the preserve-unused-selectors test to accompany this new option.

Related

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2023

⚠️ No Changeset found

Latest commit: ebd3e43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

Did you happen to notice that all of the issues you linked to were closed as won't-implement?

@Conduitry Conduitry closed this Sep 10, 2023
@Maytha8
Copy link
Author

Maytha8 commented Sep 11, 2023

What's the problem? It's a useful option that can greatly benefit those who develop with Svelte. And it's false by default.

@rkyoku
Copy link

rkyoku commented Feb 19, 2024

@Maytha8 do not bother, this member is blind to users input. So many users agree with you though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants