Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump jsdom to address word-wrap vulnerability #9046

Merged
merged 8 commits into from
Oct 5, 2023
Merged

chore: bump jsdom to address word-wrap vulnerability #9046

merged 8 commits into from
Oct 5, 2023

Conversation

benmccann
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: eb65954

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

TypeError: The "path" argument must be of type string or an instance of URL. Received an instance of URL

what a great error message, thanks

@benmccann
Copy link
Member Author

Hmm. Maybe this is not related to this PR since there are multiple other PRs failing with this same issue

@Conduitry
Copy link
Member

With the tests fixed on master, I'm merging that back into this branch. However, it looks like (at least locally for me - CI hasn't finished yet) there are still test failures, but at least they look JSDOM-related. It appears that the new version of JSDOM normalizes computed style colors to rgb(...) strings.

@benmccann
Copy link
Member Author

benmccann commented Jul 26, 2023 •
edited
Loading

Okay, for now I've downgraded to 22.0.0, which fixes the security vulnerability warning without changing the test output

I guess longer-term we'll have to update the tests. This seems to be a result of jsdom/jsdom#3560. I'll hold off on that for now to avoid creating diffs with the Svelte 5 tests

@benmccann benmccann requested a review from gtm-nayan August 22, 2023 22:01
@benmccann benmccann requested a review from dummdidumm October 4, 2023 16:37
@dummdidumm dummdidumm merged commit 4efec41 into master Oct 5, 2023
@dummdidumm dummdidumm deleted the word-wrap branch October 5, 2023 10:39
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
@benmccann @kelvinsjk
chore: bump jsdom to address word-wrap vulnerability (sveltejs#9046)
542b88a 
* chore: bump jsdom to address word-wrap vulnerability

* downgrade jsdom

* fix lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

@gtm-nayan gtm-nayan Awaiting requested review from gtm-nayan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @Conduitry @dummdidumm