Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replay function invocations on custom element #8955

Closed
wants to merge 3 commits into from
Closed

fix: replay function invocations on custom element #8955

wants to merge 3 commits into from

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 11, 2023 •
edited
Loading

fixes #8954

Marking as draft because we need to determine if we want this since it only works for functions. We should also add documentation about the behavior.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm dummdidumm mentioned this pull request Jul 11, 2023
Closed
@dummdidumm dummdidumm mentioned this pull request Jul 18, 2023
Merged
5 tasks
dummdidumm added a commit that referenced this pull request Jul 18, 2023
@dummdidumm
feat: add ability to extend custom element class (#8991)
657f113 
This should help everyone who has special needs and use cases around custom elements. Since Svelte components are wrapped and only run on connectedCallback, it makes sense to expose the custom element class for modification before that.
- fixes #8954 / closes #8955 - use extend to attach the function manually and save possible values to a prop
- closes #8473 / closes #4168 - use extend to set the proper static attribute and then call attachInternals in the constructor
- closes #8472 - use extend to attach anything custom you need
- closes #3091 - pass `this` to a prop of your choice and use it inside your component
- add some doc for #8987
@benmccann benmccann deleted the ce-function-binding branch August 22, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Elements built with Svelte 4 do not work in Home Assistant
1 participant
@dummdidumm