Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the need for node:process #8795

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Jun 22, 2023

By replacing conditional logic with performance.now(), this patch ensures improved compatibility across other environments. It avoids unnecessary polyfills triggered by seeing global process being used in code by other bundlers/CDN that don't know if they are optional or not, leading to cleaner code.

performance.now() exist in all env.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 7cbd36d into sveltejs:master Jun 22, 2023
@jimmywarting jimmywarting deleted the patch-1 branch June 22, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants