chore: produce single bundle for runtime with multiple entrypoints #8504
Conversation
|
@gtm-nayan is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We were previously producing multiple bundles I think? If it's just one bundle now, do we need to update the |
|
It's a single bundle in the sense that rollup considers all the files as part of the same bundle and links them as such. But, the output structure remains the same since there are multiple entry points now and output files defined as before for each of them. The exports don't have to be changed. |
rollup.config.mjs
Outdated
| }, | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
we've never had trailing commas before. I guess when we setup prettier it will probably remove them
There was a problem hiding this comment.
We already have a prettier config in sites repo, we can just remove the source folders from prettierignore
There was a problem hiding this comment.
We can't introduce prettier just yet, the resulting diff would cause conflicts in a lot of the pulls targeted for v4.
doesn't really make sense for a library since users' build step will do it again anyway
…8504) * single runtime bundle * formatting * dedupe output options * fix tests apparently * skip writeBundle for cjs build * revert quotes * remove manualChunks * some node16 module resolution compliance * disable minifyInternalExports (doesn't really make sense for a library since users' build step will do it again anyway)
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests
npm testand lint the project withnpm run lintref #8491
This should let us get rid of some manual import paths bookkeeping.