-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove node<14 tests #8482
chore: remove node<14 tests #8482
Conversation
@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask if we should keep 12 for awhile longer, but 20 comes out next week and 14 is EOL at the end of the month, so I think supporting 14 still is generous enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but will need to fix the test failures before merging
chcp 65001 | ||
echo ("NODE_VERSION=$(node --version)") >> $env:GITHUB_ENV | ||
if: runner.os == 'Windows' | ||
- run: npm install --save-dev puppeteer@13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would still need this, but I upgraded puppeteer
so that it's no longer necessary and we can run the tests locally. I can reproduce the test failures locally, but have no clue why they're happening
Hmm. Maybe the test failures are related to some of the recently merged PRs. I see it expecting |
leftovers from sveltejs#8022
…dumm/svelte into remove-some-node-versions
Co-authored-by: Ben McCann <[email protected]>
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests
npm test
and lint the project withnpm run lint