Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use custom event constructor instead of deprecated #8474

Closed
wants to merge 4 commits into from
+2 −3
Closed

chore: use custom event constructor instead of deprecated #8474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3d8b01
update jsdom
tronicboy1 Apr 11, 2023
baf48f7
use custom event constructor
tronicboy1 Apr 11, 2023
a85edad
add CustomEvent to test global
tronicboy1 Apr 11, 2023
f0b23c3
restore package json
tronicboy1 Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/runtime/internal/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,9 +742,7 @@ export function toggle_class(element, name, toggle) {
}

export function custom_event<T = any>(type: string, detail?: T, { bubbles = false, cancelable = false } = {}): CustomEvent<T> {
const e: CustomEvent<T> = document.createEvent('CustomEvent');
e.initCustomEvent(type, bubbles, cancelable, detail);
return e;
return new CustomEvent(type, { detail, bubbles, cancelable });
}

export function query_selector_all(selector: string, parent: HTMLElement = document.body) {
Expand Down
1 change: 1 addition & 0 deletions test/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ global.navigator = window.navigator;
global.getComputedStyle = window.getComputedStyle;
global.requestAnimationFrame = null; // placeholder, filled in using set_raf
global.window = window;
global.CustomEvent = window.CustomEvent;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add the CustomEvent constructor to the global context for tests.


// add missing ecmascript globals to window
for (const key of Object.getOwnPropertyNames(global)) {
Expand Down