Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special-case width/height attribute during spread #8412

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

dummdidumm
Copy link
Member

fixes #6752

@Conduitry please have a closer look at this - seems like there's some history with this stuff, and you might have reservations about introducing some kind of lookup table

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented Mar 23, 2023

@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm dummdidumm added this to the 3.x milestone Mar 23, 2023
src/runtime/internal/dom.ts Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Apr 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) Apr 2, 2023 3:30am

@dummdidumm dummdidumm merged commit 3a7685f into sveltejs:master Apr 11, 2023
@dummdidumm dummdidumm deleted the spread-width-height-attr branch April 11, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width of img becomes zero when using spread props
3 participants