-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: special-case width/height attribute during spread #8412
Merged
dummdidumm
merged 5 commits into
sveltejs:master
from
dummdidumm:spread-width-height-attr
Apr 11, 2023
Merged
fix: special-case width/height attribute during spread #8412
dummdidumm
merged 5 commits into
sveltejs:master
from
dummdidumm:spread-width-height-attr
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
benmccann
reviewed
Mar 23, 2023
tanhauhau
approved these changes
Mar 29, 2023
Co-authored-by: Tan Li Hau <[email protected]>
dummdidumm
commented
Mar 29, 2023
dummdidumm
commented
Mar 29, 2023
tanhauhau
approved these changes
Mar 29, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6752
@Conduitry please have a closer look at this - seems like there's some history with this stuff, and you might have reservations about introducing some kind of lookup table
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests
npm test
and lint the project withnpm run lint