Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add CustomEvent as a known global #7768

Closed
wants to merge 1 commit into from
Closed

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 7, 2022

Trying to dispatch a new CustomEvent without warning. Not sure if we need to add the other types of events to the list, it's probably rare to do a new MouseEvent.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@baseballyama
Copy link
Member

Close in favor of #7786

Thank you for your review @bluwy !

@bluwy bluwy deleted the global-custom-event branch September 4, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants