Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct variable invalidation with bind handler #7707

Closed
wants to merge 1 commit into from

Conversation

discapes
Copy link

@discapes discapes commented Jul 21, 2022

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

As per #7704:

This pull request removes behaviour that

@discapes
Copy link
Author

discapes commented Jul 21, 2022

I initially thought that the removed code was useless, since the demo that it intended to fix does not work (the one in #2444. However, after running the tests, I found that the reason that it did not work didn't affect the tests. The reason is that the reactive declarations that depend on todos are removed, which I suspect is because while optimizing the compiler assumes todos never changes directly so is never invalidated, failing to take into account that todos might be invalidated as a result of the behaviour of renderer_invalidate. I will make changes so that the test pass, which means implementing the checks I talked about in #7704. A new issue should be raised about the demo not working.

@baseballyama
Copy link
Member

baseballyama commented Aug 7, 2022

Thank you for the PR!
I have not deep dive into this yet, but we need to add tests!

@baseballyama
Copy link
Member

I run REPL of #7704 with this PR locally, but I think it doesn't fix.

Could you explain what issue will be solved by this PR? @discapes

And I think such reactive issues will be handled in Svelte4. not Svelte3.
see: #7416 (comment)

@baseballyama baseballyama added the awaiting submitter needs a reproduction, or clarification label Feb 25, 2023
@benmccann benmccann changed the title [fix] fix bind handler invalidating other variables. fix: correct variable invalidation with bind handler Mar 14, 2023
@dummdidumm
Copy link
Member

Closing since we don't really know what's this about and there is no test

@dummdidumm dummdidumm closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting submitter needs a reproduction, or clarification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants