handle set after destroy, and move destroy into shared helpers #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #744, by checking for
this._destroyed
before callingset
. Though now that I think about it, replacing theset
method withnoop
might be better... will make that change in a sec.Anyway, I also moved the
destroy
method into the shared helpers. The only bit of component-specific stuff in thedestroy
method relates to theondestroy
lifecycle hook, and that can be dealt with as an event handler. Should shave a few bytes off apps with multiple components.