Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setup function which can supply static methods/properties. Clos… #752

Merged
merged 2 commits into from
Aug 6, 2017
Merged

Added setup function which can supply static methods/properties. Clos… #752

merged 2 commits into from
Aug 6, 2017

Conversation

hperrin
Copy link
Contributor

@hperrin hperrin commented Aug 5, 2017

…es #480. Closes #578.

@hperrin
Copy link
Contributor Author

hperrin commented Aug 5, 2017

I just checked and factory static methods work with the this keyword.
screenshot from 2017-08-05 11-51-46

@hperrin
Copy link
Contributor Author

hperrin commented Aug 5, 2017

Re: the conversation in Gitter, I changed from using the this keyword in the setup function to using an argument.

@Rich-Harris Rich-Harris merged commit 4be3807 into sveltejs:master Aug 6, 2017
@Rich-Harris
Copy link
Member

awesome, thank you! Released 1.29

@dinoboff dinoboff mentioned this pull request Aug 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hperrin @Rich-Harris