[refactor] DRY out whitespace handling #7496
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spurred on by a few outstanding issues (#3168, #7493) I've just been looking into how whitespace is handled in the Svelte compiler. It seems like there's a fair bit of repetition, with some functions being copied almost directly between
render_dom
andrender_ssr
. This PR is a bid to reconcile this in the hope that it'll be easier to maintain and easier to identify the source of any discrepancies between DOM and SSR outputs. That said, it's also my first foray into the Svelte source code so there may well be something I have overlooked!Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint