Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add types field to exports #6937

Merged
merged 3 commits into from
Nov 19, 2021
Merged

[fix] add types field to exports #6937

merged 3 commits into from
Nov 19, 2021

Conversation

dummdidumm
Copy link
Member

This will be needed when TS adds the new node module resolution algorithm. It also solves microsoft/TypeScript#46860 on our end.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This will be needed when TS adds the new node module resolution algorithm. It also solves microsoft/TypeScript#46860 on our end.
@benmccann
Copy link
Member

just one comment, but otherwise lgtm

@dummdidumm dummdidumm merged commit eaa9ffa into master Nov 19, 2021
@dummdidumm dummdidumm deleted the types-exports branch November 19, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants