Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass changed boolean array to derived callbacks #6786

Closed

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Sep 29, 2021

This allows the callbacks to easily run complex update logic based on which store changed most recently.

Fixes #6777.

NOTE: I have based this PR on top of #6750 since #6750 also changes the function signature of the derived callback, and if a changed array was added to the callback function signature and then #6750 was merged later, the signature would become (stores, set, changedArray, update) which is much uglier than (stores, set, update, changedArray). That is also why this is a draft PR; once #6750 is either merged or rejected I'll convert this PR from a draft to a real PR (and also rebase it so there are no merge conflicts).

Basing this PR on top of #6750 brings the unfortunate effect that it can be hard to see this PR's changes in isolation, so I've created rmunn#1 to see this PR's changes compared to the changes in #6750. Hopefully that makes things clear enough.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This allows the callbacks to easily run complex update logic based on
which store changed most recently.
@benmccann benmccann changed the title [feat] Pass changed boolean array to derived callbacks feat: pass changed boolean array to derived callbacks Mar 14, 2023
@dummdidumm dummdidumm added this to the one day milestone Mar 20, 2023
@rmunn
Copy link
Contributor Author

rmunn commented May 29, 2023

This PR is superseded by #8656, which merges against the version-4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide "what changed" array (of Booleans) to derived stores
2 participants