Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] input value 0 for ssr #6458

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Jun 27, 2021

Fixes #4551

  • add "value" attribute for bind:value even when value is 0 or ""
  • remove "value" attribute for <select bind:value> as it is not a valid attribute for <select>

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-4551 branch 2 times, most recently from b02e01c to aa9b4fc Compare June 29, 2021 16:17
@benmccann benmccann changed the title fix input value 0 for ssr [fix] input value 0 for ssr Jun 30, 2021
@benmccann
Copy link
Member

@tanhauhau it looks like the tests might be failing with this one

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-4551 branch from aa9b4fc to 84d073a Compare July 8, 2021 02:34
@benmccann benmccann merged commit 2818567 into sveltejs:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input type range bound value 0 is omitted from ssr
2 participants