Fix #643 #644
Closed
Fix #643 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, why didn't Travis run? |
|
Nice 👍 Maybe it only runs branches on the main repo and not forks? Not sure — I just checked the settings but couldn't figure it out. Might be easier to just work on the main repo for stuff like this, as it means all collaborators can make edits (in this case, this looks like the correct fix — am just going to change |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a test.
@Rich-Harris Just would like to check that this PR is the intended behavior. While it fixes the error, I'm unsure if there are any side effects.